Fix tests

buggregator · May 1, 2024 · e2c9998 · e2c9998
1 parent f37be4b
commit e2c9998
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 5 deletions.
diff --git a/src/Config/Server/Frontend.php b/src/Config/Server/Frontend.php
@@ -13,7 +13,7 @@
  */
 final class Frontend
 {
-    /** @var int<1, max> */
+    /** @var int<1, 65535> */
     #[Env('TRAP_FRONTEND_PORT')]
     #[CliOption('ui')]
     #[XPath('/trap/frontend/@port')]

diff --git a/src/Service/Config/ConfigLoader.php b/src/Service/Config/ConfigLoader.php
@@ -16,6 +16,7 @@ final class ConfigLoader
 
     /**
      * @param null|callable(): non-empty-string $xmlProvider
+     * @psalm-suppress RiskyTruthyFalsyComparison
      */
     public function __construct(
         private Logger $logger,
@@ -57,14 +58,15 @@ public function hidrate(object $config): void
 
     /**
      * @param \ReflectionProperty $property
-     * @param array<\ReflectionAttribute> $attributes
+     * @param list<\ReflectionAttribute<ConfigAttribute>> $attributes
      */
     private function injectValue(object $config, \ReflectionProperty $property, array $attributes): void
     {
         foreach ($attributes as $attribute) {
             try {
                 $attribute = $attribute->newInstance();
 
+                /** @var mixed $value */
                 $value = match (true) {
                     $attribute instanceof XPath => $this->xml?->xpath($attribute->path)[$attribute->key],
                     $attribute instanceof Env => \getenv($attribute->name) === false ? null : \getenv($attribute->name),
@@ -78,8 +80,10 @@ private function injectValue(object $config, \ReflectionProperty $property, arra
 
                 // Cast value to the property type
                 $type = $property->getType();
+
+                /** @var mixed $result */
                 $result = match (true) {
-                    $type === null => $value,
+                    !$type instanceof \ReflectionNamedType => $value,
                     $type->allowsNull() && $value === '' => null,
                     $type->isBuiltin() => match ($type->getName()) {
                         'int' => (int) $value,

diff --git a/src/Service/Container.php b/src/Service/Container.php
@@ -41,7 +41,7 @@ public function __construct()
      * @param array $arguments Will be used if the object is created for the first time.
      * @return T
      *
-     * @psalm-suppress MoreSpecificImplementedParamType
+     * @psalm-suppress MoreSpecificImplementedParamType, InvalidReturnType
      */
     public function get(string $id, array $arguments = []): object
     {

diff --git a/tests/Unit/Service/Config/ConfigLoaderTest.php b/tests/Unit/Service/Config/ConfigLoaderTest.php
@@ -4,6 +4,7 @@
 
 namespace Buggregator\Trap\Tests\Unit\Service\Config;
 
+use Buggregator\Trap\Logger;
 use Buggregator\Trap\Service\Config\ConfigLoader;
 use Buggregator\Trap\Service\Config\XPath;
 use PHPUnit\Framework\TestCase;
@@ -33,7 +34,7 @@ public function testSimpleHydration(): void
             </trap>
             XML;
 
-        $loader = new ConfigLoader(fn() => $xml);
+        $loader = new ConfigLoader(new Logger(), null, fn() => $xml);
         $loader->hidrate($dto);
 
         self::assertTrue($dto->myBool);