Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add searching for XHProf local files #111

Merged
merged 26 commits into from
Jun 1, 2024
Merged

Add searching for XHProf local files #111

merged 26 commits into from
Jun 1, 2024

Conversation

roxblnfk
Copy link
Member

@roxblnfk roxblnfk commented May 31, 2024 •
edited
Loading

What was changed

Added FileObserver that can find xhprof files in a directory configured in php.ini

Add envs:

  • TRAP_XHPROF_SORT
  • TRAP_XHPROF_PATH

Difference between algorithms:

TRAP_XHPROF_SORT=0
image

TRAP_XHPROF_SORT=1
image

TRAP_XHPROF_SORT=2
image

TRAP_XHPROF_SORT=3
image

Checklist

@roxblnfk roxblnfk added the enhancement New feature or request label May 31, 2024
@roxblnfk roxblnfk added this to the 1.9.0 milestone May 31, 2024
@roxblnfk roxblnfk changed the title Add FilesObserver Add searching for XHProf local files May 31, 2024
@roxblnfk roxblnfk marked this pull request as draft May 31, 2024 15:40
@roxblnfk roxblnfk linked an issue May 31, 2024 that may be closed by this pull request
Scan configured profiling directories from time to time #52
Closed
@codecov Codecov
Copy link

codecov bot commented May 31, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 2.64706% with 331 lines in your changes are missing coverage. Please review.

Project coverage is 22.81%. Comparing base (3aedbe7) to head (fd1889c).

Files Patch % Lines
src/Service/FilesObserver/Converter/XHProf.php 0.00% 74 Missing ⚠️
src/Service/FilesObserver/Converter/Tree.php 0.00% 45 Missing ⚠️
src/Service/FilesObserver/Converter/Cost.php 0.00% 38 Missing ⚠️
src/Service/FilesObserver/Handler.php 0.00% 33 Missing ⚠️
src/Service/FilesObserver/FileInfo.php 0.00% 25 Missing ⚠️
src/Service/FilesObserver.php 0.00% 23 Missing ⚠️
src/Proto/Frame/Profiler/Payload.php 0.00% 20 Missing ⚠️
src/Sender/Console/Renderer/Profiler.php 0.00% 12 Missing ⚠️
src/Application.php 0.00% 10 Missing ⚠️
src/Service/FilesObserver/Converter/Edge.php 0.00% 8 Missing ⚠️
... and 13 more
Additional details and impacted files 
@@             Coverage Diff              @@
##             master     #111      +/-   ##
============================================
- Coverage     24.81%   22.81%   -2.01%     
- Complexity     1136     1232      +96     
============================================
  Files           132      146      +14     
  Lines          3469     3791     +322     
============================================
+ Hits            861      865       +4     
- Misses         2608     2926     +318

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the tests Changes in the tests label Jun 1, 2024
@roxblnfk roxblnfk marked this pull request as ready for review June 1, 2024 19:47
@roxblnfk roxblnfk merged commit a90a651 into master Jun 1, 2024
19 of 23 checks passed
@roxblnfk roxblnfk deleted the files-observer branch June 1, 2024 20:11
@roxblnfk roxblnfk mentioned this pull request Jun 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request tests Changes in the tests
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.

Scan configured profiling directories from time to time
1 participant
@roxblnfk