Remove PHP 8.4 deprecations and update test matrices #547
+6
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomlongridge
approved these changes
Dec 17, 2024
Cawllec
added a commit
that referenced
this pull request
Jan 13, 2025
* updated memory limit in fixture * moved memory increase to init * removed old increase * Remove PHP 8.4 deprecations and update test matrices (#547) * Use dev version of bugsnag-php for tests * Use in dev version of the PSR logger * Remove nullable type annotations from method signatures * Remove test dependency setup * [Pre-release] Update changelog and version for v2.28.1 release (#548) * Update changelog and version for v2.28.1 release * Update release date in changelog * Update CHANGELOG.md Co-authored-by: Tom Longridge <tom@bugsnag.com> --------- Co-authored-by: Tom Longridge <tom@bugsnag.com> --------- Co-authored-by: Aleksander Grzegorzewski <aleksander.grzegorzewski@smartbear.com> Co-authored-by: Tom Longridge <tom@bugsnag.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
This follows the changes made to the main PHP notifier in removing type annotations in method signatures that will cause deprecation warnings in PHP 8.4. It also adds PHP 8.4 to the test matrices to ensure we have coverage when required.
A check was also made for E_STRICT instances, but none were found.
This hasn't required any changes in the PSR-logger, so that will remain unchanged.
Tests
It may be difficult for CI to run through until the new version of the PHP notifier is released, however I've run through all of the test scenarios locally, they all passed, and there were no deprecation warnings during testing.