Exclude hidden folders when walking through script definitions #697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugy
requested changes
Sep 21, 2023
| files = [] | ||
| # Read config file from within directories too | ||
| for _root, _dirs, _files in os.walk(configs_dir, topdown=True): | ||
| # In place exlustion of _dirs with exlusion prefixes | ||
| _dirs[:] = [_dirs |
There was a problem hiding this comment.
This won't work, I'm afraid, since _files are not dependent on _dirs and python will iterate over all nested files anyway.
Basically, you need to use os.path.dirname(name) below to get a file's relative path (it will be ..data in your case) and check, that it doesnt start with '.'
| @@ -262,9 +262,17 @@ def load_config_model(self, name, user, parameter_values=None, skip_invalid_para | |||
| def _visit_script_configs(self, visitor): | |||
| configs_dir = self._script_configs_folder | |||
|
|
|||
| # We will ignore folders with this prefixes (ie: hidden folders) | |||
| exclude_prefixes=('.') | |||
There was a problem hiding this comment.
If you want to have a list or tuple of prefixes, you have to use ('.',) (note comma) or ['.'].
But then in the check below, you will have to iterate over prefixes, rather than doing startswith(exclude_prefixes) immediately
I'm fine, if you define just a single string, but please rename the variable then
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore hidden folders when through script definition folders.
Resolved issue: #696
I'm not sure if script definition form page permit to put definitions in a subfolders. My tests seem to show no.
If this is still the case, maybe we should add a path validation in the form to avoir hidden folders.