Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hedera REST Mirror Net support #115

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Hedera REST Mirror Net support #115

wants to merge 5 commits into from

Conversation

3Nigma
Copy link
Contributor

@3Nigma 3Nigma commented Oct 17, 2022 •
edited
Loading

  • HederaNetwork has been moved to hedera folder
    - HederaNetwork.getClient() has been changed to HederaNetwork.client (property)
  • Removed a bunch of config variables from StratoContext (see comment)
  • Removed Contract.serialize() and Contract.deserialize(...) methods since they were, most likely, never used
  • Reorganized HederaNetwork.defaults (simplified and augmented with the new rest api baseurl reference)

All tests pass except for a Given an NFT Shop, a user is able to mint one which, oddly enough, when creating a Token fails with INSUFFICIENT_TX_FEE. Could be a network fluke.

@3Nigma
#76 initial working commit with passing tests and other minor refacto…
25f80ed 
…rings around HederaNetwork/StratoContext class.
@3Nigma 3Nigma added heavy work Heavy work is expected for this contracts LiveContract/Smart contract related labels Oct 17, 2022
@3Nigma 3Nigma added this to the 0.8.1 milestone Oct 17, 2022
@3Nigma 3Nigma requested a review from victorholo October 17, 2022 07:29
3Nigma
3Nigma commented Oct 17, 2022
View reviewed changes
package.json Outdated
"dotenv": "^10.0.0",
"isomorphic-unfetch": "^3.1.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are both used by the new HederaMirrorNetwork class to fetch and deserialize the REST API network responses into valid Hashgprah SDK objects.

@3Nigma 3Nigma modified the milestones: 0.8.1, 0.8.2 Oct 20, 2022
@3Nigma
Squashed commit of the following:
146e7cd 
commit 3f5f047
Author: Victor ADASCALITEI <210908+3Nigma@users.noreply.github.com>
Date:   Tue Nov 29 16:22:29 2022 +0200

    Bumped to beta.3 and published it to beta channel instead of release one. Retracted other beta versions for 0.8.2

commit 3667929
Author: Victor ADASCALITEI <210908+3Nigma@users.noreply.github.com>
Date:   Tue Nov 29 15:32:24 2022 +0200

    Bumped to beta.2 to allow publishing the correct build. Refactored publish:npm package script to npm native's prepublishOnly one.

commit 31df149
Merge: 3c3af8c 7cc4e84
Author: Victor Holotescu <victor.holotescu@yahoo.ro>
Date:   Tue Nov 29 15:21:11 2022 +0200

    Merge pull request #132 from /issues/131-win-abs-path-imports-fix

    Windows `import` fix

commit 7cc4e84
Author: Victor ADASCALITEI <210908+3Nigma@users.noreply.github.com>
Date:   Tue Nov 29 14:32:21 2022 +0200

    Initial fix which has been manually tested to work. Unfortunately, there is no plan of having a windows test written for it at the moment. Bumped version to new beta version.

commit 3c3af8c
Merge: 353b61d 05a3c9c
Author: Victor Holotescu <victor.holotescu@yahoo.ro>
Date:   Fri Nov 25 12:27:22 2022 +0200

    Merge pull request #130 from /issues/129-sol-import-id-already-exists

    Solidity `DeclarationError` fix in `SolidityCompiler`

commit 05a3c9c
Author: Victor ADASCALITEI <210908+3Nigma@users.noreply.github.com>
Date:   Fri Nov 25 08:10:06 2022 +0200

    Bumped lib version to 0.8.2-beta.0

commit df5a11a
Author: Victor ADASCALITEI <210908+3Nigma@users.noreply.github.com>
Date:   Fri Nov 25 08:09:37 2022 +0200

    Initial commit with working fix. All tests (node & jsdom) are green

commit 353b61d
Author: Victor ADĂSCĂLIȚEI <210908+3Nigma@users.noreply.github.com>
Date:   Thu Nov 24 13:15:36 2022 +0200

    Update README.md

commit 4c38fa4
Author: Victor Holotescu <victor.holotescu@yahoo.ro>
Date:   Thu Nov 24 13:06:46 2022 +0200

    Fix tests badge

commit 0eb1dc1
Author: Victor Holotescu <victor.holotescu@yahoo.ro>
Date:   Thu Nov 24 12:44:34 2022 +0200

    Fix manual test Github Action

commit df37dea
Merge: 676b1cf 7e06cd0
Author: Victor ADĂSCĂLIȚEI <210908+3Nigma@users.noreply.github.com>
Date:   Thu Nov 24 11:03:14 2022 +0200

    Merge pull request #125 from buidler-labs/develop

    0.8.1

commit 7e06cd0
Author: Victor ADASCALITEI <210908+3Nigma@users.noreply.github.com>
Date:   Thu Nov 24 10:54:47 2022 +0200

    Renamed all occurrences of hedera-venin to hashgraph-venin

commit fba3b2e
Author: Victor ADASCALITEI <210908+3Nigma@users.noreply.github.com>
Date:   Thu Nov 24 07:57:38 2022 +0200

    Added tests for #126

commit e7b456e
Author: Victor ADASCALITEI <210908+3Nigma@users.noreply.github.com>
Date:   Thu Nov 24 07:30:29 2022 +0200

    Fixed import reference for failing test

commit a2c4b2c
Author: Victor ADASCALITEI <210908+3Nigma@users.noreply.github.com>
Date:   Thu Nov 24 07:06:32 2022 +0200

    Fixed failing tests

commit 31c4a29
Merge: afe53f6 d338119
Author: Victor Holotescu <victor.holotescu@yahoo.ro>
Date:   Wed Nov 23 15:35:45 2022 +0200

    Merge branch 'develop' of https://github.com/buidler-labs/hedera-strato-js into develop

commit afe53f6
Author: Victor Holotescu <victor.holotescu@yahoo.ro>
Date:   Wed Nov 23 15:35:12 2022 +0200

    Add HEDERAS_NODES env vars in Github Actions.

commit d338119
Merge: c6db54a 1003a65
Author: Victor ADĂSCĂLIȚEI <210908+3Nigma@users.noreply.github.com>
Date:   Wed Nov 23 15:34:25 2022 +0200

    Merge pull request #127 from buidler-labs/issues/#126-token-create-fails-with-insufficient_tx_fee

    Add support for maxTransactionFee on TokenCreate

commit c6db54a
Author: Victor Holotescu <victor.holotescu@yahoo.ro>
Date:   Wed Nov 23 15:29:40 2022 +0200

    Default to hedera-devnet environment for GitHub Actions.

commit 1003a65
Author: Victor Holotescu <victor.holotescu@yahoo.ro>
Date:   Wed Nov 23 13:20:12 2022 +0200

    Add support for maxTransactionFee on TokenCreate

commit 085f0e4
Author: Victor ADASCALITEI <210908+3Nigma@users.noreply.github.com>
Date:   Tue Nov 22 15:52:43 2022 +0200

    Renamed couple of missed references for #123 and bumped lib version to 0.8.1

commit bc9e55f
Merge: 205e80a 817e543
Author: Victor ADĂSCĂLIȚEI <210908+3Nigma@users.noreply.github.com>
Date:   Tue Nov 22 15:36:04 2022 +0200

    Merge pull request #124 from /issues/123-lib-renaming

    The king is dead, long live the king!

commit 817e543
Author: Victor ADASCALITEI <210908+3Nigma@users.noreply.github.com>
Date:   Tue Nov 22 15:29:11 2022 +0200

    Fixed npm vulnerabilities and renamed public library references to venin (and derivatives).

commit 205e80a
Merge: 278d07c ffff801
Author: Victor ADĂSCĂLIȚEI <210908+3Nigma@users.noreply.github.com>
Date:   Sat Oct 22 19:56:41 2022 +0300

    Merge pull request #118 from /issues/114-sol-relative-imports-path-fix

    Fixed `..` relative path imports for `Contract.XFrom({ path })` scenarios

commit ffff801
Author: Victor ADASCALITEI <210908+3Nigma@users.noreply.github.com>
Date:   Wed Oct 19 13:00:27 2022 +0300

    Initial fix of #114 with tests added and everything green.

commit 676b1cf
Merge: e1aa9c2 278d07c
Author: Victor ADĂSCĂLIȚEI <210908+3Nigma@users.noreply.github.com>
Date:   Fri Oct 7 16:52:51 2022 +0300

    Merge pull request #113 from buidler-labs/develop

    0.8.0
@3Nigma
Fixed failing tests for devnet. Not yet fully working, but getting there
7ab5eb2
@3Nigma
Merge branch 'develop' into issues/76-rest-mirror-net
52541c9
@3Nigma
Fixed elements affecting an important test. Everything (node/jsdom) i…
e834849 
…s green again against devnet.
@3Nigma
Copy link
Contributor Author

3Nigma commented Dec 1, 2022

Everything is green again. Awaiting review

victorholo
victorholo reviewed Dec 1, 2022
View reviewed changes
lib/hedera/HederaNetwork.ts
);
}

this.mirror = new HederaRestMirror(
Copy link
Contributor

@victorholo victorholo Dec 1, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are aware of some apps who are not using the Hedera offered mirror URLs on public networks and other service providers being available. Would we be able to accommodate custom addresses for public networks as well?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like having:

HEDERAS_NETWORK=mainnet
HEDERAS_REST_MIRROR_URL=LWorks-URL

lib/ApiSession.ts
): Promise<ExecutionReturnTypes<AllowedExecutionReturnTypes<R>>[T]> {
const isContractTransaction =
transaction instanceof ContractCallQuery ||
public async execute<R>(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very happy that we managed to simplify so much around the app with this mirror integration and at the same time provide more value for less.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victorholo victorholo victorholo left review comments

Assignees
No one assigned
Labels
contracts LiveContract/Smart contract related heavy work Heavy work is expected for this
Projects
None yet
Milestone
0.X
Development

Successfully merging this pull request may close these issues.
2 participants
@3Nigma @victorholo