Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update @Value annotations and properties-maven-plugin to correctly reference property keys #3

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Gumparthypavankumar
Copy link

Issue #, if available:

  1. What Changed?
  • Updated the @value annotations in controller to correctly reference properties, now using {} i.e @value("${property.key}")
  • Updated the properties-maven-plugin execution phase from package -> initialize to ensure property files are included in the final JAR
  1. What is the reason for change?
  • The original code had @value annotations without curly brackets as a result spring does not resolve properties, and the application did not throw errors even though properties were not being loaded
  • The previous configuration of properties-maven-plugin did not copy property files in the generated JAR
  1. Is there anything to watch out for anything particularly remarkable?
  • This fix addresses the issue of missing properties and inconsistent property resolution. There is nothing remarkable to note beyond standard fixes

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

…ion to enable proper property loading in fat JAR

1. What Changed?
  * Updated the @value annotations in controller to correctly reference properties, now using {} i.e @value("${property.key}")
  * Updated the properties-maven-plugin execution phase from package -> initialize to ensure property files are included into the final JAR
2. What is the reason for change?
  * The original code had @value annotations without curly brackets as a result spring does not resolve properties, and application did not throw errors even though properties were not being loaded
  * The previous configuration of properties-maven-plugin did not copy property files in generated JAR
3. Is there anything to watch out for anything particularly remarkable?
  * This fix addresses the issue of missing properties and inconsistent property resolution. There is nothing remarkable to note beyond standard fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant