Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bats test for Ockam examples #8076

Merged
merged 2 commits into from
Jun 25, 2024
Merged

Bats test for Ockam examples #8076

merged 2 commits into from
Jun 25, 2024

Conversation

metaclips
Copy link
Member

Current behavior

Proposed changes

Checks

  • All commits in this Pull Request are signed and Verified by Github.
  • All commits in this Pull Request follow the Ockam commit message convention.
  • There are no Merge commits in this Pull Request. Ockam repo maintains a linear commit history. We merge Pull Requests by rebasing them onto the develop branch. Rebasing to the latest develop branch and force pushing to your Pull Request branch is okay.
  • I have read and accept the Ockam Community Code of Conduct.
  • I have read and accepted the Ockam Contributor License Agreement by adding my Git/Github details in a row at the end of the CONTRIBUTORS.csv file in a separate pull request to the build-trust/ockam repository. The easiest way to do this is to edit the CONTRIBUTORS.csv file in the github web UI and create a separate Pull Request, this will mark the commit as verified.

@metaclips metaclips force-pushed the metaclips/examples_automation branch 6 times, most recently from ce26c33 to 5ae7bea Compare May 26, 2024 23:31
@metaclips metaclips force-pushed the metaclips/examples_automation branch 3 times, most recently from 8a9be8a to 086aa57 Compare June 11, 2024 18:38
@metaclips metaclips force-pushed the metaclips/examples_automation branch 21 times, most recently from 2c68883 to 0e78fef Compare June 19, 2024 18:03
@metaclips metaclips force-pushed the metaclips/examples_automation branch 8 times, most recently from 6bbb958 to 9e6586e Compare June 24, 2024 11:10
@metaclips metaclips marked this pull request as ready for review June 24, 2024 11:33
@metaclips metaclips requested a review from a team as a code owner June 24, 2024 11:33
@metaclips metaclips changed the title WIP: Bats test for Ockam examples Bats test for Ockam examples Jun 24, 2024
etorreborre
etorreborre previously approved these changes Jun 24, 2024
View reviewed changes
Copy link
Member

@etorreborre etorreborre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very impressive!

examples/command/portals/kafka/aiven/application_team/docker-compose.yml Outdated Show resolved Hide resolved
examples/command/portals/kafka/apache/docker/application_team/docker-compose.yml Outdated Show resolved Hide resolved
examples/command/portals/kafka/confluent/application_team/docker-compose.yml Outdated Show resolved Hide resolved
examples/command/portals/kafka/instaclustr/docker/application_team/docker-compose.yml Outdated Show resolved Hide resolved
examples/command/portals/kafka/redpanda/docker/application_team/docker-compose.yml Outdated Show resolved Hide resolved
examples/command/portals/kafka/warpstream/application_team/docker-compose.yml Outdated Show resolved Hide resolved
@metaclips metaclips force-pushed the metaclips/examples_automation branch from 9e6586e to 507c79c Compare June 24, 2024 16:05
adrianbenavides
adrianbenavides previously approved these changes Jun 24, 2024
View reviewed changes
Copy link
Member

@adrianbenavides adrianbenavides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!! The bats tests look really good 💪

implementations/rust/ockam/ockam_command/tests/bats/examples/databases.bats Show resolved Hide resolved
@metaclips metaclips force-pushed the metaclips/examples_automation branch from 507c79c to 1c94a1f Compare June 25, 2024 01:42
@metaclips metaclips added this pull request to the merge queue Jun 25, 2024
Merged via the queue into develop with commit 8b28af7 Jun 25, 2024
42 checks passed
@metaclips metaclips deleted the metaclips/examples_automation branch June 25, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrianbenavides adrianbenavides adrianbenavides approved these changes

@etorreborre etorreborre Awaiting requested review from etorreborre

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@metaclips @etorreborre @adrianbenavides