(elixir) use cbor on tcp transport serialization, introduce support for padding on secure channel #8226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
polvorin
commented
Jun 27, 2024
polvorin
commented
- port tcp transport layer protocol changes to elixir.
- port secure channel changes
polvorin
force-pushed
the
polvorin/transport_msg
branch
from
3704e8d to
322a00b
Compare
polvorin
changed the title
SanjoDeundiak
force-pushed
the
sanjo/transport_msg
branch
3 times, most recently
from
5df9754 to
769292e
Compare
adapt tcp transport message serialization and introduce support for padding in secure channel messages
polvorin
force-pushed
the
polvorin/transport_msg
branch
from
322a00b to
7422441
Compare
SanjoDeundiak
requested changes
Jun 28, 2024
| @@ -28,11 +28,16 @@ defmodule Ockam.Transport.TCP.Handler do | |||
|
|
|||
| {:ok, socket} = :ranch.handshake(ref, ranch_options) | |||
|
|
|||
| # Header, protocol version "1" must be the first thing exchanged. | |||
| # It isn't send anymore after the initial exchange. | |||
| {:ok, <<1>>} = transport.recv(socket, 1, 5000) | |||
There was a problem hiding this comment.
I wound change the order of these two lines. Imagine the other side doing the same and now both parties are waiting for the version number.
There was a problem hiding this comment.
ok, I assumed the connecting side send it, and receiver responded. But will update
do not wait for connecting side header
SanjoDeundiak
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.