Gem005 #79
Merged
Gem005 #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…because IfcGradientCurve is a subtype of IfcCompositeCurve
pjanck
suggested changes
Sep 22, 2023
Comment on lines
34
to
38
| #27=IFCRECTANGLEPROFILEDEF(.AREA.,$,#26,20000.,20000.); | ||
| #28=IFCCARTESIANPOINT((0.,0.,0.)); | ||
| #29=IFCAXIS2PLACEMENT3D(#28,$,$); | ||
| #30=IFCDIRECTION((0.,0.,1.)); | ||
| #31=IFCEXTRUDEDAREASOLID(#27,#29,#30,20000.); |
There was a problem hiding this comment.
While I understand that this is only a testing file, I would still recommend using plausible values. 20x20x20 kilometres body for a building seems too much.
Ghesselink
approved these changes
Sep 24, 2023
|
Everything appears addressed. Thanks all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only review 652d72a please