This repository has been archived by the owner on Feb 14, 2024. It is now read-only.
Adds support for AWS SM stored secrets #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lox
approved these changes
Oct 2, 2018
|
Possibly needs some documentation in the README? |
|
Thanks for the review :)
Good point! Done 😄 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #5 by adding basic AWS SM support. This means callers do not have to expose the secret in an environment variable (making it less likely to be logged).
This is on top of PR #12 -- so ignore the first commit from this review.Secret versions aren't yet leveraged, but that'll be tackled during rotation support (#6)