Submit annotations directly with HTTP #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the buildkite-agent is nice in theory, but becomes a pain in Docker environments. Let's try posting annotations directly to the Buildkite Agent API. We need some more gems, but they're all default/stdlib gems which should be installed anyway.
yob
reviewed
Sep 7, 2023
| uri = URI.join(agent_endpoint, "v3/jobs/#{ENV.fetch("BUILDKITE_JOB_ID")}/annotations") | ||
| headers = { | ||
| "Authorization" => "Token #{ENV.fetch("BUILDKITE_AGENT_ACCESS_TOKEN")}", | ||
| "User-Agent" => "rspec-buildkite/#{RSpec::Buildkite::VERSION}", |
|
Small bump to say that this change would be appreciated. Unfortunately, the mount-buildkite-agent does not seem to work for docker-in-docker. The workaround I found is manually installing the agent, which wastes a couple of seconds |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure yet if this is a good idea, but this branch submits annotations directly via HTTP instead of using the
buildkite-agent. I was struggling to get thebuildkite-agentbinary into a Docker Compose stack, so am trying this out of frustration.It is potentially breaking -- I had to allow
agent.buildkite.comin WebMock in my test suite to allow this to work.