Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Update Set<T> to List<T> in calendar_event.dart to comply with rrule 0.2.16 #531

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

sheng-di
Copy link

This PR addresses the type declaration change in the rrule library version 0.2.16. The library now uses List<T> instead of Set<T>, which necessitates the same change in calendar_event.dart of the builttoroam/device_calendar package.

Changes made:

  • All instances of Set<T> in calendar_event.dart have been updated to List<T>.
  • Necessary adjustments in methods/functions that were using Set<T> are made to handle List<T>.

This change ensures compatibility with the rrule library version 0.2.16 and prevents possible type errors. It is recommended to merge this PR to maintain the integrity and functionality of the builttoroam/device_calendar package.

Please review and let me know if any changes are required.

@IVLIVS-III IVLIVS-III mentioned this pull request Mar 18, 2024
@IVLIVS-III
Copy link
Contributor

@sheng-di thank you for fixing the example project that causes all tests to break.
Please rebase your branch on the top of develop. The workflow issue should be fixed by now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants