Pedantic compile with MSVC, GCC and Clang MinGW

.gitignore

@@ -40,3 +40,4 @@ CTestTestFile.cmake
 .vscode/
 .idea/
 cmake-build-debug/
+build-*/

CMakeLists.txt

@@ -4,6 +4,10 @@ cmake_policy(SET CMP0017 NEW)
 #this line has to appear before 'PROJECT' in order to be able to disable incremental linking
 SET(MSVC_INCREMENTAL_DEFAULT ON)
 
+if(TOOLCHAIN_ROOT)
+	include(MinGW64.cmake)
+endif()
+
 PROJECT(BULLET_PHYSICS)
 FILE (STRINGS "VERSION" BULLET_VERSION)
 
@@ -269,6 +273,70 @@ IF (BULLET2_USE_OPEN_MP_MULTITHREADING)
     ENDIF (MSVC)
 ENDIF (BULLET2_USE_OPEN_MP_MULTITHREADING)
 
+set(CMAKE_CXX_STANDARD 98)
+set(CMAKE_CXX_STANDARD_REQUIRED ON)
+set(CMAKE_CXX_EXTENSIONS OFF)
+IF(MSVC)
+	SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /Wall")
+	SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /wd4005") # macro redefined
+	SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /wd4061") # enumerator 'value' in switch of enum 'type' is not handled explicitly
+	SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /wd4191") # unsafe conversion of function pointers
+	SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /wd4263 /wd4264 /wd4266") # virtual function override with same name and different arguments
+	SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /wd4464") # relative include paths
+	SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /wd4512 /wd4514 /wd4623 /wd4625 /wd4626 /wd5026 /wd5027") # implicitly deleted constructor, destructor, assignment operators
+	SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /wd4548") # expression before comma has no effect; expected expression with side-effect
+	SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /wd4668") # 'symbol' is not defined as a preprocessor macro, replacing with '0' for 'directives'
+	SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /wd4710 /wd4711 /wd4714") # not inlined
+	SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /wd4820") # 'bytes' bytes padding added after construct 'member_name'
+	SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /wd4996") # tr1 namespace deprecated
+	SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /wd5031") # pragma warning(pop): likely mismatch, popping warning state pushed in different file
+	SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /wd5039") # function': pointer or reference to potentially throwing function passed to extern C function under -EHc. Undefined behavior may occur if this function throws an exception.
+	SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /wd5045") # Compiler will insert Spectre mitigation for memory load if /Qspectre switch specified
+	SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /wd5105") # macro expansion producing 'defined' has undefined behavior
+	# enet
+	SET(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} /wd4146") # unary minus operator applied to unsigned type, result still unsigned
+
+	if(CMAKE_CXX_COMPILER_VERSION VERSION_GREATER_EQUAL 19.10) # from MSVC 2017
+		SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /Zc:__cplusplus,preprocessor /permissive-")
+		SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /std:c++14") # earliest c++ standard explicitly supported
+	endif()
+	# static analyzer: 
+	SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /analyze:stacksize 65736") # static analyzer
+	# gtest:
+	SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /wd6326") # Potential comparison of a constant with another constant
+ELSE()
+	SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -Wextra -Wpedantic -Werror")
+	SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-int-to-void-pointer-cast") # hellovr, SimpleSocket
+	SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-int-to-pointer-cast") # hellovr, stb_image
+	SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-long-long") # C++98 has no long long
+	SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-variadic-macros") # C++98 variadic macros
+	SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-missing-field-initializers") # gtest, stb_image
+	IF(CMAKE_CXX_COMPILER_ID MATCHES "GNU")
+		SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-maybe-uninitialized") # gtest
+		SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-ignored-attributes") # b3Int64 cl_long
+		SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-deprecated-copy") # GIMPACT
+		SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-strict-aliasing") # GIMPACT, btSoftBody, OpenCL
+		SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-stringop-overflow") # btAlignedObjectArray - placement new
+	ELSEIF(CMAKE_CXX_COMPILER_ID MATCHES "Clang")
+		SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-zero-as-null-pointer-constant") # 0, NULL or nullptr
+		SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-deprecated-copy-with-user-provided-copy") # GIMPACT
+		SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-overloaded-virtual") # exampleBrowser OpenGLGuiHelper and btDeformable*
+		SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-null-pointer-subtraction") # btSoftBody
+		SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-invalid-offsetof") # hellovr
+	ENDIF()
+	SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wunused-but-set-parameter")
+	SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wunused-but-set-variable")
+	SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wunused-function")
+	SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wunused-label")
+	SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wunused-local-typedefs")
+	SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wunused-parameter")
+	SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wunused-variable")
+	SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wunused-value")
+	SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wunused")
+
+	#SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Xanalyzer -fanalyzer") # static analyzer
+ENDIF()
+
 IF (BULLET2_USE_TBB_MULTITHREADING)
     SET (BULLET2_TBB_INCLUDE_DIR "not found" CACHE PATH "Directory for Intel TBB includes.")
     SET (BULLET2_TBB_LIB_DIR "not found" CACHE PATH "Directory for Intel TBB libraries.")

Extras/ConvexDecomposition/ConvexBuilder.cpp

@@ -76,7 +76,7 @@ bool ConvexBuilder::isDuplicate(unsigned int i1, unsigned int i2, unsigned int i
 	return dcount == 3;
 }
 
-void ConvexBuilder::getMesh(const ConvexDecomposition::ConvexResult &cr, VertexLookup vc, UintVector &indices)
+void ConvexBuilder::getMesh(const ConvexDecomposition::ConvexResult &cr, VertexLookup vc, UintVector & /*indices*/)
 {
 	unsigned int *src = cr.mHullIndices;
 
@@ -93,6 +93,9 @@ void ConvexBuilder::getMesh(const ConvexDecomposition::ConvexResult &cr, VertexL
 		i1 = Vl_getIndex(vc, p1);
 		i2 = Vl_getIndex(vc, p2);
 		i3 = Vl_getIndex(vc, p3);
+		(void)i1;
+		(void)i2;
+		(void)i3;
 
 #if 0
 		bool duplicate = false;
@@ -138,7 +141,7 @@ CHull *ConvexBuilder::canMerge(CHull *a, CHull *b)
 
 	unsigned int vcount = Vl_getVcount(vc);
 	const float *vertices = Vl_getVertices(vc);
-	unsigned int tcount = indices.size() / 3;
+	unsigned int tcount = (unsigned int)(indices.size() / 3);
 
 	//don't do anything if hull is empty
 	if (!tcount)
@@ -207,10 +210,10 @@ bool ConvexBuilder::combineHulls(void)
 					++i;
 					while (i != mChulls.size())
 					{
-						CHull *cr = mChulls[i];
-						if (cr != match)
+						CHull *ch = mChulls[i];
+						if (ch != match)
 						{
-							output.push_back(cr);
+							output.push_back(ch);
 						}
 						i++;
 					}
@@ -283,9 +286,9 @@ unsigned int ConvexBuilder::process(const ConvexDecomposition::DecompDesc &desc)
 			hdesc.SetHullFlag(ConvexDecomposition::QF_SKIN_WIDTH);  // do skin width computation.
 		}
 
-		ConvexDecomposition::HullError ret = hl.CreateConvexHull(hdesc, result);
+		ConvexDecomposition::HullError retCreate = hl.CreateConvexHull(hdesc, result);
 
-		if (ret == ConvexDecomposition::QE_OK)
+		if (retCreate == ConvexDecomposition::QE_OK)
 		{
 			ConvexDecomposition::ConvexResult r(result.mNumOutputVertices, result.mOutputVertices, result.mNumFaces, result.mIndices);
 
@@ -311,7 +314,7 @@ unsigned int ConvexBuilder::process(const ConvexDecomposition::DecompDesc &desc)
 		delete cr;
 	}
 
-	ret = mChulls.size();
+	ret = (unsigned int)mChulls.size();
 
 	mChulls.clear();
 

Extras/ConvexDecomposition/ConvexDecomposition.cpp

@@ -318,11 +318,11 @@ void calcConvexDecomposition(unsigned int vcount,
 		// ok... here we recursively call
 		if (ifront.size())
 		{
-			unsigned int vcount = Vl_getVcount(vfront);
-			const float *vertices = Vl_getVertices(vfront);
-			unsigned int tcount = ifront.size() / 3;
+			unsigned int vertCount = Vl_getVcount(vfront);
+			const float *verts = Vl_getVertices(vfront);
+			unsigned int triCount = (unsigned int)(ifront.size() / 3);
 
-			calcConvexDecomposition(vcount, vertices, tcount, &ifront[0], callback, masterVolume, depth + 1);
+			calcConvexDecomposition(vertCount, verts, triCount, &ifront[0], callback, masterVolume, depth + 1);
 		}
 
 		ifront.clear();
@@ -331,11 +331,11 @@ void calcConvexDecomposition(unsigned int vcount,
 
 		if (iback.size())
 		{
-			unsigned int vcount = Vl_getVcount(vback);
-			const float *vertices = Vl_getVertices(vback);
-			unsigned int tcount = iback.size() / 3;
+			unsigned int vertCount = Vl_getVcount(vback);
+			const float *verts = Vl_getVertices(vback);
+			unsigned int triCount = (unsigned int)(iback.size() / 3);
 
-			calcConvexDecomposition(vcount, vertices, tcount, &iback[0], callback, masterVolume, depth + 1);
+			calcConvexDecomposition(vertCount, verts, triCount, &iback[0], callback, masterVolume, depth + 1);
 		}
 
 		iback.clear();

Extras/ConvexDecomposition/ConvexDecomposition.h

@@ -141,10 +141,10 @@ class ConvexDecompInterface
 {
 public:
 	virtual ~ConvexDecompInterface(){};
-	virtual void ConvexDebugTri(const float *p1, const float *p2, const float *p3, unsigned int color){};
-	virtual void ConvexDebugPoint(const float *p, float dist, unsigned int color){};
-	virtual void ConvexDebugBound(const float *bmin, const float *bmax, unsigned int color){};
-	virtual void ConvexDebugOBB(const float *sides, const float *matrix, unsigned int color){};
+	virtual void ConvexDebugTri(const float * /*p1*/, const float * /*p2*/, const float * /*p3*/, unsigned int /*color*/){};
+	virtual void ConvexDebugPoint(const float * /*p*/, float /*dist*/, unsigned int /*color*/){};
+	virtual void ConvexDebugBound(const float * /*bmin*/, const float * /*bmax*/, unsigned int /*color*/){};
+	virtual void ConvexDebugOBB(const float * /*sides*/, const float * /*matrix*/, unsigned int /*color*/){};
 
 	virtual void ConvexDecompResult(ConvexResult &result) = 0;
 };