Fix text artifacts in example browser#4626
Open
justincredible wants to merge 3 commits intobulletphysics:masterfrom
Open
Fix text artifacts in example browser#4626justincredible wants to merge 3 commits intobulletphysics:masterfrom
justincredible wants to merge 3 commits intobulletphysics:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4493
Thanks to @DaveH355 it was easy to
git-bisectwhere the issue was introduced (31b9be8).The diff is very short so it was quick to see the misuse of the VAO in
glBindBuffer(). The first commit is sufficient for GLX, but testing on Windows showed a need to allocate the buffer space like the position VBO (I guess WGL is more faithful to the spec. in this regard?).I also renamed the misleading variable to its supposed intended use.