Disable credential persistence in checkout action #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `persist-credentials: false` to the actions/checkout step in the build workflow to prevent GitHub tokens from being stored in `.git/config`. ## Changes - Added `persist-credentials: false` option to the checkout step in `.github/workflows/build.yml` ## Why By default, `actions/checkout` persists the GitHub token in the `.git/config` file. This can be a security risk if subsequent workflow steps or third-party actions have access to the repository directory, as they could potentially extract and misuse the token. Setting `persist-credentials: false` ensures the token is not stored after the checkout completes, following security best practices for GitHub Actions workflows. ## Semgrep Finding Details actions/checkout persists tokens into .git/config by default. Add `persist-credentials: false` to the checkout step. [https://bmbl.atlassian.net/wiki/spaces/APS/pages/3220865235/GitHub+Actions+-+Security+Vulnerabilities+And+How+to+Avoid+Them#ArtiPACKED] @ender.akbas@team.bumble.com requested Semgrep Assistant generate this pull request to fix [a finding](https://semgrep.dev/orgs/bmbl/findings/545996007).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
persist-credentials: falseto the actions/checkout step in the build workflow to prevent GitHub tokens from being stored in.git/config.Changes
persist-credentials: falseoption to the checkout step in.github/workflows/build.ymlWhy
By default,
actions/checkoutpersists the GitHub token in the.git/configfile. This can be a security risk if subsequent workflow steps or third-party actions have access to the repository directory, as they could potentially extract and misuse the token. Settingpersist-credentials: falseensures the token is not stored after the checkout completes, following security best practices for GitHub Actions workflows.Semgrep Finding Details
actions/checkout persists tokens into .git/config by default. Add
persist-credentials: falseto the checkout step. [https://bmbl.atlassian.net/wiki/spaces/APS/pages/3220865235/GitHub+Actions+-+Security+Vulnerabilities+And+How+to+Avoid+Them#ArtiPACKED]@ender.akbas@team.bumble.com requested Semgrep Assistant generate this pull request to fix a finding.