Skip to content

Conversation

@madonk
Copy link
Collaborator

@madonk madonk commented Dec 12, 2013

Closes #399.

…tured automatically every second during recording.
@burg
Copy link
Owner

burg commented Dec 14, 2013

This is good work. I think you should try to make screenshots a new type of profile instead, because the current approach doesn't fit well with existing timeline data gathering mechanism (which is pushed entirely by the backend). Adding a new profile type is not much work, and the calls to the backend and UI views can be easily reused. Plus, then we don't need to add a new timeline and fiddle with the styles (they are going to be changed soon anyway).

@xeenon
Copy link

xeenon commented Dec 21, 2013

FWIW, we are removing the concept of Profiles soon. Everything will be a Timeline. I think a Timeline makes sense for this, considering we will be a few optional Timelines that you can add or remove — this could be one.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reset this to remove the whitespace changes, so I'm not sure if my version was just out of date or not….

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a new timeline type for capturing screenshots on a recurring timer

3 participants