Skip to content

Correctly reimplement #177#1

Closed
ivanpu wants to merge 1 commit intoburodepeper:patch-1from
ivanpu:patch-3
Closed

Correctly reimplement #177#1
ivanpu wants to merge 1 commit intoburodepeper:patch-1from
ivanpu:patch-3

Conversation

@ivanpu
Copy link

@ivanpu ivanpu commented Mar 17, 2019

atom#177 does not do what you want: str1 || str2 returns str1 if not empty, str2 otherwise

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

A fix for atom#185, by rewriting the atom#177.

Alternate Designs

['source.gfm', 'text.md'].includes(grammarScopeName)

Benefits

No more whitespace stripping in Markdown.

Possible Drawbacks

None?

Applicable Issues

atom#185, atom#186, atom#177

atom#177 does not do what you want: `str1 || str2` returns `str1` if not empty, `str2` otherwise
@ivanpu
Copy link
Author

ivanpu commented Mar 17, 2019

A note: after submitting this, I see that there's already atom#186 (that I accidentally linked to instead of atom#185).
So decision is your which PR to use.

@ivanpu
Copy link
Author

ivanpu commented Mar 17, 2019

Oops... went to the wrong repo?

@burodepeper
Copy link
Owner

Yup, wrong repo ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants