Update dependencies #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the requirement of `aws-sdk-cloudformation` is `~> 1.67.0` which prevents upgrading to 1.68.0 and later in projects where cuffsert is a dependency. This relaxes the requirement to `~> 1.67`. Same for `aws-sdk-s3`.
This tests with the latest version Ruby, which is currently 3.4.1 This also removes Gemfile.lock, since it should not be under version control, since it enforces precision that does not exist in the gemspec.
The method `File.exists?` has been deprecated since Ruby 2.2.0, and was finally removed in 3.2.0.
Since Ruby 3.4, the gem `base64` is a "bundled" gem, instead of a "default" gem, and needs to be added to the Gemfile. It is used in the `aws-sdk-cloudformation` gem, but they have not added it as a dependency to not break running older versions of Ruby, therefore we don't add it as a runtime dependency here either. Similar situation with `logger` which will be removed in Ruby 3.5.
stenlarsson
force-pushed
the
update-dependencies
branch
from
1c5db65 to
7300795
Compare
bittrance
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the requirement of
aws-sdk-cloudformationis~> 1.67.0which prevents upgrading to 1.68.0 and later in projects where cuffsert is a dependency.This relaxes the requirement to
~> 1.67. Same foraws-sdk-s3.This tests with the latest version Ruby, which is currently 3.4.1. This also removes Gemfile.lock, since it should not be under version control, since it enforces precision that does not exist in the gemspec. This makes it possible that different versions are used when testing with Ruby 2.x and 3.x.
The method
File.exists?has been deprecated since Ruby 2.2.0, and was finally removed in 3.2.0.Since Ruby 3.4.0, the gem
base64is a "bundled" gem, instead of a "default" gem, and needs to be added to the Gemfile. It is used in theaws-sdk-cloudformationgem, but they have not added it as a dependency to not break running older versions of Ruby, see aws/aws-sdk-ruby#2984. Therefore we don't add it as a runtime dependency here either.Similar situation with
loggerwhich will be removed in Ruby 3.5.0.