Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing webhook thread endpoints and allow overriding webhook message attachments #1390

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

merlinfuchs
Copy link
Contributor

This PR adds the missing attachments field to the WebhookEdit struct so you can remove and override attachments on webhook messages. See https://discord.com/developers/docs/resources/webhook#edit-webhook-message

It also adds the missing thread specific equivalents to the WebhookMessage, WebhookMessageEdit, and WebhookMessageDelete endpoints.

@FedorLap2006
Copy link
Collaborator

Thank you for implementing these missing features, however, I think it's a good idea to separate the endpoint and attachment changes into different PRs, since they have completely different scopes.

@FedorLap2006 FedorLap2006 added the feature Major feature implementation label Jun 17, 2023
@FedorLap2006 FedorLap2006 self-assigned this Jun 17, 2023
@merlinfuchs
Copy link
Contributor Author

#1392 adds the attachments parameter so I will remove it from this PR

@FedorLap2006 FedorLap2006 added this to the v0.28.0 milestone Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Major feature implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants