Add Entitlements / SKUs #1552
Open
Add Entitlements / SKUs #1552
+446
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhoffi
commented
Aug 14, 2024
glotchimo
reviewed
Sep 11, 2024
glotchimo
approved these changes
Oct 10, 2024
| // When the subscription was canceled. Only present if the subscription has been canceled. | ||
| CanceledAt *time.Time `json:"canceled_at,omitempty"` | ||
|
|
||
| // ISO3166-1 alpha-2 country code of the payment source used to purchase the subscription. Missing unless queried with a private OAuth scope. |
structs.go
Outdated
| @@ -2467,7 +2509,7 @@ type Entitlement struct { | |||
|
|
|||
| // The ID of the user that is granted access to the entitlement's sku | |||
| // Only available for user subscriptions. | |||
| UserID string `json:"user_id,omitempty"` | |||
| UserID *string `json:"user_id,omitempty"` | |||
There was a problem hiding this comment.
Is there ever a point at which we'd expect/want a default string value here? Wondering if the introduction of pointer risk is necessary or if we can roll with default values without losing any important data (no user has no ID, no guild has no ID, no entitlement has a start time at zero, etc.)
There was a problem hiding this comment.
You are right, thank you. However, I would keep all the optional timestamps as pointers, since this is also done in other structs (e.g., Channel, Member, Invite).
|
Is this approved can it be merged? |
AFAIK we're waiting on maintainer approval |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of Entitlements and SKUs.