Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

srt: generate unique name for backup file #73

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

schdub
Copy link

@schdub schdub commented Mar 19, 2018

If .bak file exist, then its contents are taken as the source file.

reproducing the error situation

# source file contents
$ cat 1.srt
1
00:00:01,111 --> 00:00:03,646
Line 1

2
00:00:07,569 --> 00:00:10,058
Line 2

# good
$ srt -i shift -10ms 1.srt && cat 1.srt
1
00:00:01,101 --> 00:00:03,636
Line 1

2
00:00:07,559 --> 00:00:10,048
Line 2

# fail
$ srt -i shift -10ms 1.srt && cat 1.srt
1
00:00:01,101 --> 00:00:03,636
Line 1

2
00:00:07,559 --> 00:00:10,048
Line 2

# fail
$ srt -i shift -20ms 1.srt && cat 1.srt
1
00:00:01,091 --> 00:00:03,626
Line 1

2
00:00:07,549 --> 00:00:10,038
Line 2

My solution is generate unique name for bak file.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 70.876% when pulling bfc452f on schdub:master into e23ca39 on byroot:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 70.876% when pulling bfc452f on schdub:master into e23ca39 on byroot:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 70.876% when pulling bfc452f on schdub:master into e23ca39 on byroot:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants