Skip to content

Conversation

@marko-kriskovic
Copy link
Collaborator

@marko-kriskovic marko-kriskovic commented Nov 25, 2025

The commits with Reapply were accidentally merged and then Reverted so the order is should be them first and then the 2 commits after.
Reapply commit 2e3686d caused one regression where you couldn't add connections to any node in a task dispatcher. This has been fixed in 1c3a7e6.
Reapply commit 989af6c takes in account all nodes of same type when creating a new node and naming it {node_type}_{current_number+1}, accounting for the ones in task dispatchers and cluster elements.
Commits 1c3a7e6 and 9539b63 need to be looked into as they may cause regression. It primarily modifies WorkflowNodeDetailsPanel.tsx.
Commit b2c5b48 can be reverted without breaking anything. It exists to please sonarqube error.
This sill works incorrectly with vector databases.

@kresimir-coko
Copy link
Collaborator

Izbjegavaj force push jer se onda ne može pratiti razlika unutar samog PR-a, na primjer ja sad ne mogu vidit promjene na kodu od zadnjeg review-a - praktički opet moran sve reviewat a ne samo nove promjene

Copy link
Collaborator

@kresimir-coko kresimir-coko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bolje! još par sitnica i to je to

@marko-kriskovic
Copy link
Collaborator Author

@kresimir-coko done!

@marko-kriskovic
Copy link
Collaborator Author

nemoj još mergat, rekao je Ivica da moram još lokaciju nodova sredit

Copy link
Collaborator

@kresimir-coko kresimir-coko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bravo 👏

@kresimir-coko kresimir-coko marked this pull request as draft December 8, 2025 07:36
@marko-kriskovic marko-kriskovic marked this pull request as ready for review December 8, 2025 09:10
@marko-kriskovic
Copy link
Collaborator Author

marko-kriskovic commented Dec 8, 2025

@kresimir-coko ok spremno je. bit će merge conflict sa Property.tsx. to su trenutno 2 totalno različita filea

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed for 'client'

Failed conditions
0.6% Coverage on New Code (required ≥ 80%)
6.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@kresimir-coko kresimir-coko merged commit 5fc6d65 into master Dec 11, 2025
6 of 7 checks passed
@kresimir-coko kresimir-coko deleted the 2867_front branch December 11, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants