Use drain instead of clear (#123)

bytecodealliance · Apr 6, 2023 · f0e9cde · f0e9cde
1 parent 9c6d6dc
commit f0e9cde
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/src/ion/redundant_moves.rs b/src/ion/redundant_moves.rs
@@ -111,19 +111,18 @@ impl RedundantMoveEliminator {
     pub fn clear_alloc(&mut self, alloc: Allocation) {
         trace!("   redundant move eliminator: clear {:?}", alloc);
         if let Some(ref mut existing_copies) = self.reverse_allocs.get_mut(&alloc) {
-            for to_inval in existing_copies.iter() {
+            for to_inval in existing_copies.drain(..) {
                 trace!("     -> clear existing copy: {:?}", to_inval);
-                if let Some(val) = self.allocs.get_mut(to_inval) {
+                if let Some(val) = self.allocs.get_mut(&to_inval) {
                     match val {
                         RedundantMoveState::Copy(_, Some(vreg)) => {
                             *val = RedundantMoveState::Orig(*vreg);
                         }
                         _ => *val = RedundantMoveState::None,
                     }
                 }
-                self.allocs.remove(to_inval);
+                self.allocs.remove(&to_inval);
             }
-            existing_copies.clear();
         }
         self.allocs.remove(&alloc);
     }