Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the manpage example #60

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Fix the manpage example #60

merged 1 commit into from
Dec 13, 2023

Conversation

hankbao
Copy link
Contributor

@hankbao hankbao commented Dec 12, 2023

I found the output of the manpage example regarding the POLLIN event quite confusing. It ought to be true. But it is false because the pollfd is copied mistakenly.

$ cargo run --example manpage -- 1
...

fault_handler_thread():
    poll() returns: nready = 1; POLLIN = false; POLLERR = false

...

@pchickey
Copy link
Collaborator

Thank you for this fix! I had to go review our (retired) use of these functions and we seem to have gotten it right in production, at least, even if the readme has been wrong for a long time.

@pchickey pchickey merged commit 9f1631b into bytecodealliance:main Dec 13, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants