Use wit_bindgen in rust library #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abrown
reviewed
Oct 28, 2024
rust/Cargo.toml
Outdated
| @@ -1,6 +1,6 @@ | |||
| [package] | |||
| name = "wasi-nn" | |||
| version = "0.6.0" | |||
| version = "25.0.2" | |||
There was a problem hiding this comment.
Can we just move this version to 0.7.0?
There was a problem hiding this comment.
Thanks! I think @jlb6740 is going to take a look at this PR further; thanks for the contribution!
|
Hi @TiejunMS .. I think the workflow file causing the CI failure should be updated to omit regenerating bindings from witx. Did you want to submit that along with the changes here? |
Sure. I can simply remove this workflow. |
|
Thanks @jlb6740 ! Do you know when this crate will be published? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.