[Rust] fix length calculation in stream.write bindings#1157
Merged
dicej merged 1 commit intobytecodealliance:mainfrom Feb 6, 2025
Merged
[Rust] fix length calculation in stream.write bindings#1157dicej merged 1 commit intobytecodealliance:mainfrom
stream.write bindings#1157dicej merged 1 commit intobytecodealliance:mainfrom
Conversation
When calculating the length we pass to the `stream.write` intrinsic, we need to subtract the number of bytes we've already written. I forgot to do that in my original PR. Signed-off-by: Joel Dice <joel.dice@fermyon.com>
alexcrichton
approved these changes
Feb 6, 2025
dicej
added a commit
to dicej/wasip3-components
that referenced
this pull request
Feb 6, 2025
bytecodealliance/wit-bindgen#1157 Also, minor code cleanup. Signed-off-by: Joel Dice <joel.dice@fermyon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When calculating the length we pass to the
stream.writeintrinsic, we need to subtract the number of bytes we've already written. I forgot to do that in my original PR.