Skip to content

Conversation

@ZacBlanco
Copy link
Collaborator

What problem does this PR solve?

Use pre-commit checks as CI jobs to prevent relying on pre-commit checks locally. There have already been some PRs which break the formatting rules in the pre-commit checks introduced by #113

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 🚀 Performance improvement (optimization)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)
  • 🔨 Refactoring (no logic changes)
  • 🔧 Build/CI or Infrastructure changes
  • 📝 Documentation only

Description

Breaks up the pre-commit checks in pre-commit-config.yaml into individual jobs that are run against all repository files to make sure formatting is not broken by contributors who may not have used the pre-commit checks during development.

Performance Impact

  • No Impact: This change does not affect the critical path (e.g., build system, doc, error handling).
  • Positive Impact: I have run benchmarks.
  • Negative Impact: Explained below (e.g., trade-off for correctness).

Release Note

N/A

Checklist (For Author)

  • I have added/updated unit tests (ctest).
  • I have verified the code with local build (Release/Debug).
  • I have run clang-format / linters.
  • (Optional) I have run Sanitizers (ASAN/TSAN) locally for complex C++ changes.
  • No need to test or manual test.

Breaking Changes

  • No
  • Yes (Description: ...)

@ZacBlanco ZacBlanco force-pushed the ci-precommit-checks branch 3 times, most recently from 7939e11 to ad0409a Compare January 15, 2026 03:52
@ZacBlanco ZacBlanco marked this pull request as ready for review January 15, 2026 04:14
@ZacBlanco ZacBlanco requested a review from yangzhg January 15, 2026 04:15
@ZacBlanco ZacBlanco force-pushed the ci-precommit-checks branch 2 times, most recently from bda35a5 to f0434d4 Compare January 15, 2026 17:29
Copy link
Collaborator

@yangzhg yangzhg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This is better for maintainability as you don't need to edit the
pre-commit-config AND the github workflow. Better to just
keep it all in one place.
@ZacBlanco ZacBlanco force-pushed the ci-precommit-checks branch from f0434d4 to de36eb8 Compare January 16, 2026 18:10
@ZacBlanco ZacBlanco force-pushed the ci-precommit-checks branch from c7ff7d3 to 1da4993 Compare January 16, 2026 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants