add sve support for isAscii #132
Open
+20
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yangzhg
reviewed
Jan 19, 2026
| size_t i = 0; | ||
| const size_t sve_vector_size = svcntb(); | ||
| while (i < length) { | ||
| svbool_t pgTail = svwhilelt_b8(i, length); |
Collaborator
There was a problem hiding this comment.
Does svwhilelt_b8 need a header file ?
yangzhg
reviewed
Jan 19, 2026
| return true; | ||
| return true; | ||
| #else | ||
| for (auto i = 0; i < length; i++) { |
Collaborator
There was a problem hiding this comment.
add a x86 implements using _mm256_loadu_si256 and _mm256_movemask_epi8 ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #126
Type of Change
Description
Added an SVE vectorized implementation for facebook::velox::functions::stringCore::isAscii.
Performance Impact
Release Note
Please describe the changes in this PR
Release Note:
Checklist (For Author)
Breaking Changes