Skip to content

Conversation

@luozenglin
Copy link
Collaborator

@luozenglin luozenglin commented Jan 15, 2026

What problem does this PR solve?

Issue Number: close #148

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 🚀 Performance improvement (optimization)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)
  • 🔨 Refactoring (no logic changes)
  • 🔧 Build/CI or Infrastructure changes
  • 📝 Documentation only

Description

Extend exportToArrow to support exporting complex vectors that are:

  • DictionaryVector-encoded complex types
  • ConstantVector-encoded complex types

Performance Impact

  • No Impact: This change does not affect the critical path (e.g., build system, doc, error handling).

  • Positive Impact: I have run benchmarks.

    Click to view Benchmark Results
    Paste your google-benchmark or TPC-H results here.
    Before: 10.5s
    After:   8.2s  (+20%)
    
  • Negative Impact: Explained below (e.g., trade-off for correctness).

Release Note

Please describe the changes in this PR

Release Note:

Release Note:
- Support exporting dictionary/constant encoded complex VectorPtrs in exportToArrow

Checklist (For Author)

  • I have added/updated unit tests (ctest).
  • I have verified the code with local build (Release/Debug).
  • I have run clang-format / linters.
  • (Optional) I have run Sanitizers (ASAN/TSAN) locally for complex C++ changes.
  • No need to test or manual test.

Breaking Changes

  • No

  • Yes (Description: ...)

    Click to view Breaking Changes
    Breaking Changes:
    - Description of the breaking change.
    - Possible solutions or workarounds.
    - Any other relevant information.
    

@CLAassistant
Copy link

CLAassistant commented Jan 15, 2026

CLA assistant check
All committers have signed the CLA.

@yangzhg
Copy link
Collaborator

yangzhg commented Jan 16, 2026

It's better to create an issue to describe problem

@luozenglin luozenglin force-pushed the export_dict_complex branch 4 times, most recently from bdb50d2 to c28887f Compare January 16, 2026 09:39
@luozenglin
Copy link
Collaborator Author

It's better to create an issue to describe problem

done

Copy link
Collaborator

@yangzhg yangzhg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

… type

Co-authored-by: Zhang Xiaofeng <xiaofeng.zhang@bytedance.com>
@luozenglin luozenglin merged commit 5d13883 into bytedance:main Jan 19, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Support exporting dictionary/constant encoded complex VectorPtrs in exportToArrow

3 participants