Fix parser usage in multiple compilation units #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIx INI parser usage in multiple .cpp compilation units linked together.
If A.cpp and B.cpp both include "INI.h" they each export the same functions causing one definition rule violation during linking stage.
To avoid this problem, templated methods implementation has to be declared 'inline' and other supporting functions 'static'.
Because class static member
INI::PARSE_FLAGSis not constant, it should be initialized only once. Currently each .cpp that includes the header is doing the initialization and generates undefined initialiation order error. Those variables need to be static per compilation unit.API change:
class static members
INI::PARSE_FLAGSINI::SAVE_FLAGSmoved out of class and renamed/made into static global variables, that can be initialized to unique values in each compilation unit.