Skip to content
This repository was archived by the owner on May 19, 2019. It is now read-only.

Conversation

@IpShot
Copy link

@IpShot IpShot commented Mar 19, 2016

Added simple indexes with String, Number and Date types support

@c58
Copy link
Owner

c58 commented Mar 19, 2016

  1. Make all tests passing please
  2. Add tests for IndexManager (from https://github.com/IpShot/marsdb/blob/indexes/test/both/IndexManager.test.js)
  3. Use indexes in DocumentRetriver for queries like that: {field: 'some_id'}, {field: {$in: [1,2,3]}}. So, i think getMatching(...) must have some query analyzing logic from DocumentRetriver, and DocumentRetiver must get appropriate index from IndexManager and just use it to get some ids for scan. In other words, getMatching must work with plain-object arguments too and DocumentRetriver must delegate query analyzing to getMatching of some index (or retrive all if no index found)

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 90.559% when pulling 25805c8 on IpShot:simple_indexes into e3c157e on c58:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 90.559% when pulling 4850fee on IpShot:simple_indexes into e3c157e on c58:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 90.55% when pulling 8101008 on IpShot:simple_indexes into e3c157e on c58:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 90.545% when pulling 690ab60 on IpShot:simple_indexes into e3c157e on c58:master.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants