Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade circleci config version and improve api/security tests #11325

Merged
merged 28 commits into from
Jan 7, 2025

Conversation

zainasir
Copy link
Member

@zainasir zainasir commented Jan 7, 2025

Describe changes proposed in this pull request:

  • Combine security tests and api tests into a single workflow.
  • Optimize image builds, reducing test time by 50%.
  • Eliminate manual approval needed for docker authentication.

Docker Scout can be modified to use native comparison functionality once it is not in experimental stage anymore.

Checks

Any screenshots or GIFs?

(Before) Old Tests Dependency Graph

Screenshot 2025-01-07 at 2 47 35 PM

(After) New Tests Dependency Graph

Screenshot 2025-01-07 at 3 10 22 PM

Notify reviewers

Read our Pull request merging
policy
. It can help to figure out who worked on the
file before you. Please use git blame <filename> to determine that
and notify them either through slack or by assigning them as a reviewer on the PR

@zainasir zainasir added the test label Jan 7, 2025
@zainasir zainasir requested a review from inodb January 7, 2025 02:57
Copy link
Member

@inodb inodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you!

Copy link

sonarqubecloud bot commented Jan 7, 2025

@zainasir zainasir merged commit 600691b into master Jan 7, 2025
26 of 27 checks passed
@zainasir zainasir deleted the fix/circleci-tests branch January 7, 2025 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants