Skip to content

Commit

Permalink
Merge pull request #176 from cabcookie:improve-person-mention
Browse files Browse the repository at this point in the history
Meetings weiter optimieren
  • Loading branch information
cabcookie authored Aug 8, 2024
2 parents 3a3686c + cbc75ea commit 1f41afa
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 8 deletions.
9 changes: 7 additions & 2 deletions components/meetings/meeting-activity-list.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
import { useProjectsContext } from "@/api/ContextProjects";
import { Meeting } from "@/api/useMeetings";
import { getTextFromEditorJsonContent } from "@/helpers/ui-notes-writer";
import { flow, join, map } from "lodash/fp";
import { FC } from "react";
import ActivityComponent from "../activities/activity";
import TaskBadge from "../task/TaskBadge";
Expand All @@ -21,14 +23,17 @@ const MeetingActivityList: FC<MeetingActivityListProps> = ({ meeting }) => {
<DefaultAccordionItem
value={a.id}
key={a.id}
triggerTitle="Meeting notes"
triggerTitle={getProjectNamesByIds(a.projectIds)}
badge={
<TaskBadge
hasOpenTasks={a.hasOpenTasks}
hasClosedTasks={!!a.closedTasks?.length}
/>
}
triggerSubTitle={`Projects: ${getProjectNamesByIds(a.projectIds)}`}
triggerSubTitle={`Next actions: ${flow(
map(getTextFromEditorJsonContent),
join(", ")
)(a.openTasks)}`}
>
<ActivityComponent
activityId={a.id}
Expand Down
3 changes: 0 additions & 3 deletions components/meetings/meeting.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ import PeopleSelector from "../ui-elements/selectors/people-selector";
import ProjectSelector from "../ui-elements/selectors/project-selector";
import { Accordion } from "../ui/accordion";
import MeetingActivityList from "./meeting-activity-list";
import MeetingNextActions from "./meeting-next-actions";
import MeetingParticipants from "./meeting-participants";
import MeetingProjectRecommender from "./meeting-project-recommender";

Expand Down Expand Up @@ -155,8 +154,6 @@ const MeetingRecord: FC<MeetingRecordProps> = ({
removeParticipant={removeMeetingParticipant}
/>

<MeetingNextActions meeting={meeting} />

<MeetingActivityList meeting={meeting} />
</>
)}
Expand Down
4 changes: 1 addition & 3 deletions docs/releases/next.md
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
# Meetings weiter optimieren (Version :VERSION)

- In Meetings werden Projekte angezeigt, bei denen die Teilnehmer schon einmal in Meetings involviert gewesen sind. Wenn ein Projekt angeklickt wird, wird es direkt dem Meeting hinzugefügt und man kann anfangen, Notizen zu machen.
- In Meetings können Teilnehmer wieder entfernt werden, wenn man sie versehentlich hinzugefügt hat.
- In der Detailansicht einer Person werden im Untertitel von Notizen nur noch Projekte angezeigt, in die die Person involviert ist, die aber noch nicht abgeschlossen sind.
- Statt "Meeting notes" steht nun das konkrete Projekt im Kopf des Accordions und die vereinbarten nächsten Schritte im Untertitel.

## In Arbeit

Expand Down

0 comments on commit 1f41afa

Please sign in to comment.