Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Conditionally link devenv profile for python-rewrite #847

Merged
merged 2 commits into from
Oct 23, 2023

Conversation

penguincoder
Copy link
Contributor

This is functionally the same as #844 but for the python-rewrite branch.

When loading a shell, devenv checks .devenv/profile is

1. not a link
2. readlink reports someplace other than ${profile}

Then will remove whatever is .devenv/profile and relink to the current
active profile. When running a single command at a time, this is
usually not a problem, but if you attempt to run two commands at the
same time, then the race condition of one process removing a link while
another is creating the link will emit warnings to stderr.
@penguincoder penguincoder changed the title [BUG] Use a full path mktemp to not leave orphans in $DEVENV_ROOT [BUG] Use a full path mktemp to not leave orphans in $DEVENV_ROOT for python-rewrite Oct 19, 2023
@penguincoder penguincoder changed the title [BUG] Use a full path mktemp to not leave orphans in $DEVENV_ROOT for python-rewrite [FEAT] Conditionally link devenv profile for python-rewrite Oct 20, 2023
@domenkozar domenkozar merged commit 0afbca5 into cachix:python-rewrite Oct 23, 2023
118 of 177 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants