Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore example devenv.lock files #893

Merged
merged 2 commits into from
Dec 10, 2023

Conversation

mmlb
Copy link
Contributor

@mmlb mmlb commented Dec 8, 2023

I noticed this while running devenv-test-example scripts, that devenv.lock files are not being tracked in git except for varnish. It looks like that was a mistake so I dropped it and added devenv.lock to .gitignore.

mmlb added 2 commits December 8, 2023 12:26
None of the other examples have devenv.lock files and nothing mentioned
it in the commit message so I'm going to assume this was a mistake.
So example devenv.lock files are not accidentally added.
Copy link
Contributor

@shyim shyim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it's soo annoying 👍

@domenkozar domenkozar merged commit 3abb84a into cachix:main Dec 10, 2023
9 of 190 checks passed
@mmlb mmlb deleted the ignore-example-devenv.lock-files branch December 11, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants