-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use HTTP tracer if env var is set #6483
base: master
Are you sure you want to change the base?
Conversation
Added another commit primarily to offload the work to OTEL's autoexport function. Hopefully this will eventually allow us to send logs to OTEL as well. |
Had to revert that last commit. It didn't seem to work as advertised. |
Un reverting the revert. My test was actually flawed and it was working |
Note this will just get it to function the same way as before. There's a lot missing in Caddy's OTEL messages. To name a fiew
|
Thanks for working on this. We'll revisit this shortly as we prepare the 2.9 beta releases! In the meantime how would you feel about resolving the merge conflicts |
maybe this weekend, I only work on it on during my hobby hours |
Fixes #5743
Tested via example from https://github.com/trajano/trajano-portfolio/blob/master/Dockerfile#L17-L24
Using Grafana.com to receive the OTEL traces.
This would require a change to the tracing documentation https://caddyserver.com/docs/caddyfile/directives/tracing#tracing