Implement precise lock lease renewal for storage backends that support lease renewal. #347
+127
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t lease renewal. - Added:`LockLeaseRenewer` interface to support renewing lock leases. `renewLockLease` function to extend lease duration based on retry attempts. - Updated certificate management functions to renew lock leases during long-running retry loops. - Added tests for lease renewal functionality in `config_test.go` to ensure correct behavior with and without lease support.
zoltan-frm
force-pushed
the
feature/controlled-certstore-locks
branch
from
43b13c9 to
0412a9b
Compare
Contributor
Author
|
Hi @mholt , this has been in production for a week with us. Although the number of ACME requests have not been dramatically reduced, we would be happy to have it, as it is still beneficial to avoid races across instances. |
mholt
approved these changes
Sep 3, 2025
Member
mholt
left a comment
mholt
left a comment
There was a problem hiding this comment.
Sounds good, thanks! Will merge this in.
Am working on the "stateless" solving next.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LockLeaseRenewerinterface to support renewing lock leases.renewLockLeasefunction to extend lease duration based on retry attempts.config_test.goto ensure correct behavior with and without lease support.