chore: use math/rand/v2 instead of math/rand #363
+6
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mholt
requested changes
Jan 12, 2026
Member
mholt
left a comment
mholt
left a comment
There was a problem hiding this comment.
Thanks Weidi! I just noticed one thing I wanted to check on.
| key := fmt.Sprintf("rw_test_%d", weakrand.Int()) | ||
| contents := make([]byte, 1024*10) // size sufficient for one or two ACME resources | ||
| _, err := weakrand.Read(contents) | ||
| _, err := rand.Read(contents) |
Member
There was a problem hiding this comment.
Suggested change
| _, err := rand.Read(contents) | |
| _, err := weakrand.Read(contents) |
Should be weakrand, right?
Member
Author
There was a problem hiding this comment.
Is this supposed to be cryptographically secure? math/rand/v2 doesn't have a package level 'Read' but it's easy to fill the content using random number generators.
| "errors" | ||
| "fmt" | ||
| "math/rand" | ||
| "math/rand/v2" |
Member
There was a problem hiding this comment.
I wonder if we should import this as weakrand for consistency with other files. It's a convention that helps ensure readers know the package is not strong enough for cryptographic use. But then again I guess linters do this too, so I dunno.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to 7413.