Skip to content

Conversation

@jaydrogers
Copy link

@jaydrogers jaydrogers commented Aug 27, 2025

⚠️ This is PR depends on a change in "certmagic"

Do not merge this PR until the related PR below has been merged & released. This change will only make sense if this change in certmagic is made available:

What this PR does

  • Adds .test as an "internal-only host name"

More information on this change

See the certmagic PR above for more information explaining this proposed change.

@jaydrogers
Copy link
Author

After further discussion, this PR should not be merged.

It is not safe to assume that .test cannot solve ACME challenges. It is possible for ACME challenges to be completed internally, there for it could create a trusted certificate.

@jaydrogers jaydrogers closed this Sep 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant