Adding test. #1

caduandrade · Sep 25, 2023 · 602378f · 602378f
1 parent e4538d8
commit 602378f
Show file tree

Hide file tree

Showing 3 changed files with 45 additions and 2 deletions.
diff --git a/lib/src/layout/layout_parser.dart b/lib/src/layout/layout_parser.dart
@@ -57,8 +57,8 @@ class LayoutParser {
   /// V1:1:1(1;I;.2;;100;5;my_id;7;my_name;8;my_value;T;;F)
   String stringify(
       {required DockingLayout layout,
-       IdToString? idToString,
-       ValueToString? valueToString}) {
+      IdToString? idToString,
+      ValueToString? valueToString}) {
     final List<DockingArea> areas = layout.layoutAreas();
 
     String str = 'V1:${areas.length}:';
@@ -197,6 +197,9 @@ class LayoutParser {
     List<String> indexes = [];
     for (int i = 0; i < parent.childrenCount; i++) {
       final DockingArea child = parent.childAt(i);
+      if (child.index == -1) {
+        throw StateError('Child does not belong to any layout.');
+      }
       indexes.add(child.index.toString());
     }
     return indexes.join(',');

diff --git a/test/exceptions.dart b/test/exceptions.dart
@@ -12,3 +12,8 @@ Matcher dockingAreaInSomeLayoutException() {
       x is ArgumentError &&
       x.message == "DockingArea already belongs to some layout."));
 }
+
+Matcher childNotBelongAnyLayoutException() {
+  return throwsA(predicate((x) =>
+      x is StateError && x.message == "Child does not belong to any layout."));
+}
diff --git a/test/layout_stringify_test.dart b/test/layout_stringify_test.dart
@@ -0,0 +1,35 @@
+import 'package:docking/docking.dart';
+import 'package:flutter_test/flutter_test.dart';
+
+import 'exceptions.dart';
+import 'utils.dart';
+
+void main() {
+  final LayoutParser parser = LayoutParser();
+
+  group('LayoutParser - stringify', () {
+    test('stringifyParent', () {
+      DockingItem itemA = dockingItem('a');
+      DockingItem itemB = dockingItem('b');
+      DockingItem itemC = dockingItem('c');
+      DockingItem itemD = dockingItem('d');
+      DockingItem itemE = dockingItem('e');
+      DockingRow row = DockingRow([itemB, itemC]);
+      DockingTabs tabs = DockingTabs([itemD, itemE]);
+      DockingColumn column = DockingColumn([itemA, row, tabs]);
+
+      expect(() => parser.stringifyParent(parent: column),
+          childNotBelongAnyLayoutException());
+      expect(() => parser.stringifyParent(parent: row),
+          childNotBelongAnyLayoutException());
+      expect(() => parser.stringifyParent(parent: tabs),
+          childNotBelongAnyLayoutException());
+
+      DockingLayout(root: column);
+
+      expect(parser.stringifyParent(parent: column), '2,3,6');
+      expect(parser.stringifyParent(parent: row), '4,5');
+      expect(parser.stringifyParent(parent: tabs), '7,8');
+    });
+  });
+}