fix: fix DWARF file indices in the debug_line section

[Kamirus]

Instructions how to run it and how I've verified it when testing the motoko_debugger:

• Switch to this branch in the motoko repo and execute nix develop (this will put the locally build moc in the PATH)
• Have the motoko-core repo checkout on the branch kamil/experiment-debugger-manual-test next to this repo, go there: cd ../motoko-core (here we have the test files we would like to debug)
• Clone and build the motoko_debugger
• make -C ../motoko/src moc && moc $(mops sources) -o MoDe.wasm -g --legacy-persistence test/List.test.mo && ~/motoko_debugger/target/release/debugger MoDe.wasm. It builds the moc compiler and then compiles the problematic List test file, and finally runs the debugger on it. It should start and run to the end without problems now.

The debug line section in DWARF can be verified with

• make -C ../motoko/src moc && moc $(mops sources) -o MoDe.wasm -g --legacy-persistence test/List.test.mo && llvm-dwarfdump --debug-line MoDe.wasm > out
• open the out file in the editor and look for the File column, the file indices should not exceed the number of files

The only relevant changes are in the src/wasm-exts/customModuleEncode.ml file. The other changes (compared with master) are due to an unrelated issue. I'll change the target of the branch to the branch related to that fix to limit the number of changes files in this PR. Do not merge

[github-actions]

Comparing from c850d22 to 34b3fd0:
The produced WebAssembly code seems to be completely unchanged.

[hapeeeeee]

hi bro, after clone this repo, and run `sudo nix --extra-experimental-features 'nix-command flakes' develop
i got

error: input 'https://github.com/viperproject/viperserver/releases/download/v.22.11-release/viperserver.jar' is unsupported`

how can i fix it？

[Kamirus]

hi bro, after clone this repo, and run `sudo nix --extra-experimental-features 'nix-command flakes' develop i got

error: input 'https://github.com/viperproject/viperserver/releases/download/v.22.11-release/viperserver.jar' is unsupported`

how can i fix it？

Sorry for late reply I was on vacation. Here is the link how to do the setup. Did you followed it and still encountered this issue?

[hapeeeeee]

Here is the link how to do the setup. Did you followed it and still encountered this issue?

yes, it still exist.

[Kamirus]

Here is the link how to do the setup. Did you followed it and still encountered this issue?

yes, it still exist.

Maybe the issue is installing and using nix via sudo? I have no idea otherwise, I've asked internally the team if they are aware how to fix your issue

[hapeeeeee]

Could you share a precompiled moc binary (x86_64-linux) in which the “file index too high” issue has already been fixed?
I’d like to use it to check whether the “file index: out of bound” problem mentioned in scalebit/motoko_debugger#4 still exists.

Or, if you have already tested it, are there any other issues remaining?

[Kamirus]

I've tested it and updated my findings in caffeinelabs/motoko-core#327.
Together with the fix to moc (this PR) and the resolved File not found I think the debugger works pretty well!

[crusso]

Looks ok to me. I guess it would be slightly better if this list was populated from the code generators, and not here, but it's fine.

[Kamirus]

Could you share a precompiled moc binary (x86_64-linux) in which the “file index too high” issue has already been fixed? I’d like to use it to check whether the “file index: out of bound” problem mentioned in scalebit/motoko_debugger#4 still exists.

Or, if you have already tested it, are there any other issues remaining?

You can grab the precompiled moc from this draft release