Skip to content

Conversation

@Kamirus
Copy link
Contributor

@Kamirus Kamirus commented Dec 15, 2025

An alternative to #5605 (see the description there)
this variant avoids mutating the expression state when performing the redundant instantiation check.

Risks: coverage' must be disabled during that check, because PreLit is not allowed there. Are there any other places where PreLit would cause assert false exception?

@Kamirus Kamirus closed this Dec 15, 2025
@Kamirus Kamirus reopened this Dec 15, 2025
@Kamirus Kamirus changed the title experiment: Fix redundant instantiation check Alternative 2, failed fix: Redundant type instantiation to check all places and avoid false positives (Alternative) Dec 15, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 15, 2025

Comparing from 00bb412 to ad87d2f:
The produced WebAssembly code seems to be completely unchanged.
In terms of gas, no changes are observed in 5 tests.
In terms of size, no changes are observed in 5 tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants