Update KeyboardLayoutHelper and AppBarWindow #54
Conversation
| helper = new WindowInteropHelper(this); | ||
| Handle = helper.Handle; | ||
|
|
||
| WindowHelper.SetWindowNoActivate(Handle); |
There was a problem hiding this comment.
Why? Generally AppBars should be able to take focus.
There was a problem hiding this comment.
If it will take a focus, Windows-like layout switcher located on menu bar wouldn't able to switch current layout language for focused window. (because it will take focus for itself)
It doesn't matter when keyboard layout is system-wide in Windows. (but if layout is window-wide that will cause some problems that I had encountered)
We can remember last window that was focused before Cairo and then change it layout, but it will be a strange workaround imo.
There was a problem hiding this comment.
Taskbar.behavior.mp4
Cairo.behavior.mp4
Cairo.behavior.without.WS_EX_NOACTIVATE.mp4
There was a problem hiding this comment.
The AppBar should still take focus (e.g., so you can change the input method for Cairo when searching), what shouldn't take focus is only the input indicator (e.g., so that you can change the input method for the current app window if enabled).
There was a problem hiding this comment.
I thought about this way, but how it could be implemented?
p.s. interesting to find out, why it should take focus?
There was a problem hiding this comment.
Try to make sure that the input indicator control does not receive focus when clicked.
If I remember correctly, some AppBars, as in RetroBar, need focus for the windows to be behind the taskbar.
|
Ah, I forgot about different layout types, so I'm implementing it now... |
|
There is no way to get KLID (keyboard layout ID) from HKL (locale identifier) or current KLIDs list, that's bad. So the only workaround is... switch to every layout and get every KLID for layout type determining. Also we can't get localized keyboard layout names. :( |
|
I did some work a while back attempting this with Cairo. Let me see if I can see what I got locally. |
@josuave Did you find this by chance? |
Most changes come from: cairoshell#54
No description provided.