Bump node16 to node20 to fix deprecation #49
Conversation
These version updates are also for using current Node version (20). No need to do manual cache with newer setup-node versions as caching is now built in.
These version updates are also for using current Node version (20). No need to do manual cache with newer setup-node versions as caching is now built in.
|
however I can see test GHA is failing, please take a look to make it green |
> npm WARN deprecated @zeit/ncc@0.22.3: @zeit/ncc is no longer maintained. Please use @vercel/ncc instead.
|
@cakeinpanic thank you. FWIW the last build on default branch also failed but since it's been several months the logs are no longer available. I'm not familiar with what could be causing the error but I wonder if much like updating the node version, that the package dependencies are just out of date. For example, in the "install" step (Run npm ci --production), there are many warnings. I believe what could be causing the initial error is the ncc package so I will try to resolve that now. In the meantime, this is what I see currently for I'll push another update shortly. |
This doesn't seem to be used as I see no reference anywhere in source other than the package.json file: https://github.com/search?q=repo%3Acakeinpanic%2Fjira-description-action%20webhook&type=code This package reports a deprecation warning on npm install in CI: > npm WARN deprecated @octokit/webhooks-definitions@3.67.3: Use @octokit/webhooks-types, @octokit/webhooks-schemas, or @octokit/webhooks-examples instead. See octokit/webhooks#447 Instead of using one of the packages I figure it was safest and easiest to just remove it if its unused which seems to be the case from what I can tell.
|
@cakeinpanic I've pushed another update but you'll need to approve the CI run. Note that the install step in CI reports many warnings, most are security related. I've addressed only 2 as the packages are deprecated but there are more listed. It's likely they are transient dependencies rather than direct ones (e.g. request, resolve-url, source-map-resolve, etc.). This may require more updates to get passing again so I'll need your help. |
|
@cakeinpanic thank you. This is ready as CI is now green. After this, I will open new PRs to remove any unused dependencies as I have spotted some and learned more since about how Node based GHA's are set up. |
|
@javierjulio thank you for your contribution! |
This action is emitting a node16 deprecation warning on workflow runs. This now uses node20. I followed #27 as it's the same type of change. I wasn't sure if the package.json change is necessary. Likely best to update when updating dependency versions.
The tests workflows were updated to use the latest actions versions since those were done for the same reason, using node20 as a minimum. The manual caching was removed as that capability is now built in to actions/setup-node.
Closes #48