Updated CouchDB datasource for CakePHP 2.0 #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed from cakeError() to MissingConnectionException() Added method to search for the latest revision updates without the review Change the query() method to let you use the methods of socket freely
| @@ -25,13 +26,27 @@ | |||
| * @package datasources | |||
| * @subpackage datasources.models.datasources | |||
| */ | |||
| class CouchdbSource extends DataSource { | |||
| class CouchDBSource extends DataSource { | |||
There was a problem hiding this comment.
Is that necessary - Perhaps add a todo to rename the class which we can do at the next major release (rather than force this update to be further delayed until after the next major release)
|
I've left some feedback that needs addressing; I realize this PR is eons old - are you still interested in cleaning up the PR to merge it? If not no worries, and thanks for the effort =). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fitness for CakePHP 2.0
Changed from cakeError() to MissingConnectionException()
Added method to search for the latest revision updates without the review
Change the query() method to let you use the methods of socket freely
Example:
$this->Model->curlGet('_all_dbs');
$this->Model->curlPut('document_name');
$this->Model->curlPost('document_name', array('field' => 'value'));
$this->Model->curlDelete('document_name');
$this->Model->curlPost('document_name', array('field' => 'value'), false);
$this->Model->curlPost('document_name', array('field' => 'value'), true , false);