Single Deploy Settings #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To me it's not immediately obvious what the word "live" means in this context. I wonder if we changed that to "deployed"? It's intended for anything not running locally using runserver, right? |
|
Not the greatest name. Didn't want to name it for an environment like |
|
@vkurup gave another vote for |
|
Any outstanding objections before merging this? |
|
👍 from me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #102. All environments use a single
livesettings and configure changes via environment variables. The current is pass to allowifblocks (an example is included for Vagrant). Also related to #103 but there are still a few places like the fabfile which hard code the staging/production expectation. Hoping to address that when adding GPG secrets support. That will make added a new environment pretty straight forward: one new pillar file and minimalfabtask to set master IP, environment name.Hopefully this will also clear up the confusion about how to use Vagrant. Vagrant, like all other environments, use the production requirements and settings. It's not perfect but it's a start. Feedback welcome.