-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to support Django versions < 5.0 #16
Conversation
pyproject.toml
Outdated
@@ -14,9 +14,10 @@ include = [ { path = "tests", format = "sdist" } ] | |||
[tool.poetry.dependencies] | |||
python = ">=3.8" | |||
RapidSMS = ">=2.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RapidSMS
might need to be upgraded, it seems to be crashing this build: https://github.com/caktus/rapidsms-smpp-gateway/actions/runs/5581453954/jobs/10199938046?pr=16#step:6:67
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to the rapidsms fix, it could be worth adding tox to this repo, to test against both Django 3.2 and 4.2 (and different versions of Python). See django_bread for an example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Maybe changes.md
should be updated with release notes?
.pre-commit-config.yaml
Outdated
@@ -9,6 +9,11 @@ repos: | |||
language: system | |||
pass_filenames: false | |||
types: ["file", "python"] | |||
- repo: https://github.com/adamchainz/django-upgrade | |||
rev: 1.14.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How would you feel about updating other hooks? flake8
, isort
, etc to the latest version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That sounds good to me, I'll see what I can do.
Python 3.9 is failing in Github actions with the following error:
However,
|
Yes, this PR depends on RapidSMS being updated to support Django 4.2 then this should go away. But the PR for that upgrade is failing for 3.10 for some odd reason. |
1ff3fc8
to
7f4467b
Compare
7f4467b
to
7af8351
Compare
smpplib
until a bug fix PR has been merged, noted in the toml file.django-upgrade