Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase timeout and disable Postgres notify on send #27

Merged
merged 5 commits into from
Dec 4, 2024
Merged

Increase timeout and disable Postgres notify on send #27

merged 5 commits into from
Dec 4, 2024

Conversation

tobiasmcnulty
Copy link
Member

@tobiasmcnulty tobiasmcnulty commented Nov 15, 2024 •
edited
Loading

A/C:

  • Separates the underlying socket_timeout (default: 30 seconds) from event_loop_timeout (default: 5 seconds), and makes both configurable
  • Sends a Postgres NOTIFY only for MTMessages with a priority_flag of 2 or higher

@tobiasmcnulty @copelco
Increase timeout and disable Postgres notify on send
0e34fdc 
Co-authored-by: Colin Copeland <copelco@caktusgroup.com>
tobiasmcnulty
tobiasmcnulty commented Nov 15, 2024
View reviewed changes
src/smpp_gateway/outgoing.py Outdated Show resolved Hide resolved
src/smpp_gateway/management/commands/smpp_client.py Outdated Show resolved Hide resolved
@tobiasmcnulty tobiasmcnulty marked this pull request as ready for review November 15, 2024 21:13
@tobiasmcnulty tobiasmcnulty merged commit ae73d04 into main Dec 4, 2024
5 checks passed
@tobiasmcnulty tobiasmcnulty deleted the timeout branch December 4, 2024 13:54
@tobiasmcnulty tobiasmcnulty mentioned this pull request Dec 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonkagwi simonkagwi simonkagwi left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tobiasmcnulty @simonkagwi