CI: deploy Azure Web App with GitHub Actions #2111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we're moving away from using the branch-based tags and associated webhooks, so we won't need this image tag
replaces the old webhooks-based deployment
thekaveman
force-pushed
the
ci/actions-deploy
branch
from
9b8223a to
98fc86a
Compare
Coverage report
This PR does not seem to contain any modification to coverable code. |
|
OK! I'm going to merge and see if this works... 🤞 If it all looks good, I'll continue with the checklist above. |
Confirming the deploy to
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1880
This PR replaces usage of GitHub webhooks for the
package.publishevent that trigger the Azure Web App image pull + restart, with theazure/webapps-deployaction step. Using this actions step, we can target the specific Web App (e.g.dev,test, orprod) that needs to be deployed/restarted, and avoid the current situation where thepackage.publishevent triggers a restart in all 3 environments, regardless of which branch/environment was deployed.Use of a Publish Profile avoids needing a Microsoft Entra ID generated Service Principle.
Following the outline on Deploy a custom container to App Service using GitHub Actions.
Post-merge follow-up
devtestContainer Registryoption) in the Azure App Service "Deployment Center"; instead choose theGitHub ActionsoptionGitHub Actionsdeploy; don't generate a workflow file, we'll use the existing oneAZURE_WEBAPP_NAMEto hold the name of the Azure App Service,AS-CDT-PUB-VIP-CALITP-T-001AZURE_WEBAPP_PUBLISH_PROFILEto hold the contents of the Publish Profile for this App ServiceprodContainer Registryoption) in the Azure App Service "Deployment Center"; instead choose theGitHub ActionsoptionGitHub Actionsdeploy; don't generate a workflow file, we'll use the existing oneAZURE_WEBAPP_NAMEto hold the name of the Azure App Service,AS-CDT-PUB-VIP-CALITP-P-001AZURE_WEBAPP_PUBLISH_PROFILEto hold the contents of the Publish Profile for this App Service