Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: process multiple claims on a flow #2463

Merged
merged 3 commits into from
Oct 28, 2024
Merged

Conversation

lalver1
Copy link
Member

@lalver1 lalver1 commented Oct 18, 2024

Part of #2355

This PR implements a way to distinguish between older adult and disabled Medicare sessions. EnrollmentFlow is modified so that it now stores a "main" claim and an optional set of "extra" claims. An @property method on the model takes care of arranging them into one list of claims. The code now handles this list of claims everywhere that multiple claims are involved. session has been modified to store and process this list of claims to make it available to verify and analytics. Updating analytics will probably be part of a separate PR.

@lalver1 lalver1 self-assigned this Oct 18, 2024
@github-actions github-actions bot added tests Related to automated testing (unit, UI, integration, etc.) back-end Django views, sessions, middleware, models, migrations etc. deployment-dev [auto] Changes that will trigger a deploy if merged to dev migrations [auto] Review for potential model changes/needed data migrations updates labels Oct 18, 2024
Copy link

github-actions bot commented Oct 18, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  benefits/core
  models.py
  session.py
  benefits/eligibility
  verify.py
  views.py
  benefits/oauth
  views.py
Project Total  

This report was generated by python-coverage-comment-action

benefits/core/models.py Outdated Show resolved Hide resolved
@lalver1 lalver1 force-pushed the feat/older-adult-disabled branch 2 times, most recently from 57ba9b1 to 632d610 Compare October 18, 2024 20:11
@lalver1 lalver1 marked this pull request as ready for review October 18, 2024 20:34
@lalver1 lalver1 requested a review from a team as a code owner October 18, 2024 20:34
benefits/core/models.py Outdated Show resolved Hide resolved
Copy link
Member

@angela-tran angela-tran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noted some minor fixes to make to some unit tests. Other than that and what @thekaveman pointed out, the main code changes here look good!

tests/pytest/core/test_session.py Outdated Show resolved Hide resolved
tests/pytest/core/test_session.py Outdated Show resolved Hide resolved
Copy link
Member

@angela-tran angela-tran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@thekaveman thekaveman changed the title Feat: distinguish between Older Adult and Disabled riders Feat: process multiple claims on a flow Oct 28, 2024
Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lalver1 lalver1 merged commit 9ed721c into main Oct 28, 2024
15 checks passed
@lalver1 lalver1 deleted the feat/older-adult-disabled branch October 28, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
back-end Django views, sessions, middleware, models, migrations etc. deployment-dev [auto] Changes that will trigger a deploy if merged to dev migrations [auto] Review for potential model changes/needed data migrations updates tests Related to automated testing (unit, UI, integration, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants